lorenzoaiello / terraform-aws-rds-alarms

This Terraform module manages Cloudwatch Alarms for an RDS instance.
https://registry.terraform.io/modules/lorenzoaiello/rds-alarms/aws
MIT License
37 stars 36 forks source link

Feature Request/Interest: Disable certain types checks #7

Closed jbarno closed 2 years ago

jbarno commented 3 years ago

I'm wondering if there's anybody else out there whose using this module and wished they could configure only a subset of these alarms. Perhaps passing an enabled = False boolean in for the various types of checks. Loosely I think it could be:

These can then be used in the aws_cloudwatch_metric_alarm resources as the cpu_credit resource does for the count parameter.

As of right now I just define variables such that the alarm won't actually ever alarm, which isn't ideal. I'd be willing to fork and give this a try if there's interest. Or if there's another way to accomplish this please enlighten me.

AndrewFarley commented 2 years ago

Implemented in #13