search

lorenzofox3 / zora

Lightest, yet Fastest Javascript test runner for nodejs and browsers
MIT License
539 stars 93 forks source link

Fix comparison of Maps, Sets, and TypedArrays #176

Closed jwhitaker-swiftnav closed 1 year ago

jwhitaker-swiftnav commented 1 year ago

As per #174 , this includes fixed for comparisons of Maps, Sets, and TypedArrays.

EDIT: reporting stuff removed.

lorenzofox3 commented 1 year ago

Thanks ! it looks promising.

I'll pick the first commits to have two different PRs.

Getting the reporting sane without just punting on a fix for https://github.com/lorenzofox3/zora/issues/133 seems a bit futile. For the sake of getting something in, I've made the reporters report as {"Map": {"k":"v",...}}, which I wouldn't be surprised if you aren't a fan of. I'm not too sure what else can be done with the current design, though.

I think you did pretty well. Serialization is not an easy topic. If for TAP a "simple" console.log should be enough (...in many case), that would be a different story for the diff reporter where we go beyond the basic printing task

jwhitaker-swiftnav commented 1 year ago

there you go, that's just the comparison commits

jwhitaker-swiftnav commented 1 year ago

woop, i'm around from now if you want to discuss anything closer to realtime