search

lorenzofox3 / zora

Lightest, yet Fastest Javascript test runner for nodejs and browsers
MIT License
539 stars 93 forks source link

change disableFont to colors.dim #179

Closed jwhitaker-swiftnav closed 11 months ago

jwhitaker-swiftnav commented 1 year ago

On my terminal (GNOME Terminal on Pop!_OS 22.04), with the default (dark) colour scheme, the colors.gray color used by disableFont is illegible. I tried a few other terminal colour scheme / palette combinations, and colors.gray is illegible on about half of them. Is there any chance of changing it to colors.dim instead?

Screenshot before: image

Screenshot after: image

lorenzofox3 commented 1 year ago

This one is a bit tricky cause the output depends quite a lot on your OS etc. I had the idea to use various themes or even give the possibility to the user to add a theme file (basic json).

This would not be too difficult to implement cause the whole theme is injectable, but it would take some time to streamline it a little bit and I never found the motivation to do it

jwhitaker-swiftnav commented 1 year ago

yup, if it was anything other than dim (e.g. some some other arbitrary colour) i wouldn't have considered it reasonable for zora to change. However the thought here is that dim should be adaptive to whatever console theme is selected, so it should be a more widely-applicable default.

EDIT: also, what colorette calls "gray" actually maps to ANSI "bright black", whatever that means haha. it's arguable one shouldn't use black as a text color without specifying a light background, maybe the same argument can apply to bright black.