lorenzwalthert / touchstone

Smart benchmarking of pull requests with statistical confidence
https://lorenzwalthert.github.io/touchstone
Other
53 stars 7 forks source link

Proactively go for feedback #97

Open lorenzwalthert opened 2 years ago

lorenzwalthert commented 2 years ago

Identify repos that could benefit from {touchstone} and help them setting it up:

assignUser commented 2 years ago

oh thats' a good idea!

assignUser commented 2 years ago

data.table has on open issue, should I go ahead and pitch {touchstone}? Or wait till after #95 is merged?

lorenzwalthert commented 2 years ago

Let's wait for #95. And then tell them we'll contribute it to ropensci and submit to CRAN 🥳

mjskay commented 2 years ago

FWIW --- I've been lurking on here awaiting your first CRAN release after which we'll probably try out using {touchstone} with {posterior} https://github.com/stan-dev/posterior/issues/159. We definitely have need for it! :)

assignUser commented 2 years ago

Hey @mjskay thanks for dropping stealth 😄

As you probably have seen we are getting ready to submit to ropensci and afterwards CRAN, so our API should be pretty much stable by now. I would greatly appreciate any feedback on usability and function from a third party (currently @lorenzwalthert and I are the only users of the package afaik) prior to our CRAN release.

Maybe you can give it a try once #95 is merged?

mjskay commented 2 years ago

Thanks, it's good to know your intended timeline. If I have time (busy quarter atm) I'll give it a try after #95 is merged and let you know if I run into anything.

lorenzwalthert commented 2 years ago

The maintainers of {greta} also seem to be keen to try this out (https://github.com/greta-dev/greta/issues/365).

assignUser commented 2 years ago

@lorenzwalthert I think we are now ready to go "Klinkenputzen", don't you think?

lorenzwalthert commented 2 years ago

I agree yes.

lorenzwalthert commented 2 years ago

https://github.com/dirkschumacher/ompr could be a candidate, also in the light of https://twitter.com/dirk_sch/status/1487039412886192128

lorenzwalthert commented 2 years ago

https://github.com/greta-dev/greta/runs/6824667937?check_suite_focus=true seems to fail...

assignUser commented 2 years ago

@lorenzwalthert Ok looked into it, that is a side effect of the new optional trigger. Even if the workflow is skipped when an issue comment is created that does not contain /benchmark it still triggers the comment workflow that then has no idea whats happening and fails :D I'll open an issue and implement a fix

lorenzwalthert commented 2 years ago

Thanks for the quick response.