Closed louis-langholtz closed 1 year ago
PLAYRHO_REAL_FETCH
PLAYRHO_REAL_GIT_REPOSITORY
PLAYRHO_REAL_GIT_TAG
GetInvalid
realnumb
AlmostEqual
nextafter
Real
Used the following command line invocation of CMake with these changes and confirmed compile & reasonable behavior of unit tests:
CC=/opt/homebrew/opt/llvm/bin/clang \ CXX=/opt/homebrew/opt/llvm/bin/clang++ \ LDFLAGS='-L/opt/homebrew/opt/llvm/lib/c++' \ cmake -S PlayRho -B PlayRhoBuild \ -DPLAYRHO_BUILD_UNIT_TESTS=ON \ -DPLAYRHO_BUILD_BENCHMARK=ON \ -DPLAYRHO_BUILD_TESTBED=ON \ -DPLAYRHO_BUILD_HELLOWORLD=ON \ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ -DPLAYRHO_BUILD_DOC=ON \ -DPLAYRHO_ENABLE_BOOST_UNITS=ON \ -DPLAYRHO_REAL_TYPE='::realnumb::fixed64' \ -DPLAYRHO_REAL_INCLUDE='#include <realnumb/fixed.hpp>;#include <realnumb/fixed_math.hpp>;#include <realnumb/fixed_limits.hpp>' \ -DPLAYRHO_REAL_FETCH=realnumb \ -DPLAYRHO_REAL_GIT_REPOSITORY=https://github.com/louis-langholtz/realnumb.git \ -DPLAYRHO_REAL_GIT_TAG=main \ -DPLAYRHO_INSTALL=ON \ -DREALNUMB_INSTALL=ON
clang-tidy review says "All clean, LGTM! :+1:"
coverage: 99.205%. remained the same when pulling 5b327aceb0b516869495a54ca810a99d2a949380 on updates-20231020 into d07ab4ac70a95f69b06aba8df0e9a08bfcaa45b2 on master.
Description - What's this PR do?
PLAYRHO_REAL_FETCH
: names a package for CMake to fetch.PLAYRHO_REAL_GIT_REPOSITORY
: specifies git repository to fetch from.PLAYRHO_REAL_GIT_TAG
: specifies tag of git sources to actually get.GetInvalid
.realnumb
external fixed point support.AlmostEqual
to be more generic.AlmostEqual
to usenextafter
instead of epsilon.Real
.Test Info
Used the following command line invocation of CMake with these changes and confirmed compile & reasonable behavior of unit tests:
Related Issues