search

lowRISC / manticore

Apache License 2.0
16 stars 13 forks source link

server: Initial support for the AC-RoT #70

Closed alistair23 closed 11 months ago

alistair23 commented 3 years ago

This PR focuses on initial support for the AC-RoT.

In terms of responding to requests the AC-RoT is pretty much identical to the PA-RoT responding to requests. To allow us to reuse the code this PR splits out the process_request() function into a trait and then has a generic RoT struct that is used by both AC-RoT and PA-RoT. As Rust doesn't have inheritance this ends up being the simplest way that I could think of to handle this.

This way in the future the AC-RoT and PA-RoT can have specific functions added (for example send_request()) and also add new traits to extend shared functionality.

mcy commented 3 years ago

This is super cool! It'll take some time to review, so please ping me on slack or similar if I fall behind!

mcy commented 3 years ago

Haven't had time to look at this again. Just letting you know I haven't forgotten! I'm hoping to get to it this week maybe.

alistair23 commented 3 years ago

Rebased

alistair23 commented 3 years ago

Ping!

alistair23 commented 3 years ago

Ping

alistair23 commented 3 years ago

Ping!

alistair23 commented 3 years ago

Ping!

alistair23 commented 11 months ago

Closing as this appears unmaintained