search

lowRISC / manticore

Apache License 2.0
16 stars 13 forks source link

Fix for Clippy not checking tests #98

Closed Cypher1 closed 3 years ago

Cypher1 commented 3 years ago

Small fix for https://github.com/lowRISC/manticore/issues/80

mcy commented 3 years ago

Turns out Clippy doesn't like my tests. =) Can you throw #![allow(clippy::unusual_byte_groupings)] on the crate root?

mcy commented 3 years ago

Please squash the new commit into the previous one, so that CI passes at each commit.

Cypher1 commented 3 years ago

In my experience Github does that on commit, but I can do it manually.

Cypher1 commented 3 years ago

I have squashed my commits and also rebased on main. I have also checked the changes locally to ensure no new lint issues were added.

mcy commented 3 years ago

We have this repo set up so that it rebases the PR branch on top of master and then splats the result onto master. It's useful for breaking a PR up into nice pieces and retaining their commit messages. =)