search

lphuberdeau / Neo4j-PHP-OGM

A doctrine2 style library to access neo4j graphs
156 stars 45 forks source link

Repositiory now implements Doctrine\Common\Persistence\ObjectRepository #79

Open Deltachaos opened 10 years ago

Deltachaos commented 10 years ago

Because all Repositiories should implement this interface

frne commented 10 years ago

@Deltachaos I'm currently managing to implement the Doctrine Common interfaces (especially ObjectManager and ObjectRepository) correctly. This is definitively a need, but I don't see the benefit of implementing interfaces and throwing exceptions if they are used as originally intended by Doctrine Common.

lphuberdeau commented 10 years ago

If it can be supported, we should support the arguments, not just accept them to respect the interface. That would be breaking the contract.

If the argument cannot be implemented for technical reasons, then I agree on an exception to avoid false promises.

frne commented 10 years ago

@lphuberdeau Working on a solution based on #74 which also implements the ObjectManager interface. Will propose, once it's final ;)

BTW. Thx 4 merge...