search

lrongyi / pe

0 stars 0 forks source link

Functionality Bug: Unable to add chinese characters #8

Open lrongyi opened 2 weeks ago

lrongyi commented 2 weeks ago

Description

Unable to add name with chinese characters

image.png

Steps to Reproduce

  1. add n/和 p/9999999 e/email@asd.com a/home t/Low Risk m/none

Expected Behavior

Adds the name as it is valid

Actual Behavior

Error message: Names should only contain alphanumeric characters, spaces,slashes(/) and hyphens, and it should not be blank or purely numeric

Note: Severity high as it is very possible that many patients have chinese names or names of other languages with non-alphanumeric symbols.

soc-pe-bot commented 1 week ago

Team's Response

It is mentioned that in the Developer Guide, under Planned Enhancements:

  1. Error Validation for CliSyntax: Making sure the system checks if the user enters any unexpected or incorrect symbols. If the user does, the system will let them know what the correct options are, helping avoid confusion and mistakes.

We acknowledge that this is an error that we plan to fix in future iterations.

Furthermore, we did mention that the name is limited to certain special characters only:

NAME The string must be alphanumeric and contain at least one alphabetic character (i.e., it cannot consist entirely of numbers). Special characters allowed are space (‘ ‘), slash (‘/’), and hyphen (‘-‘).

Since it is mentioned in the CS2103T website that if a bug is reported as under Planned Enhancements, it should be rejected.

telegram-cloud-photo-size-5-6183777665652212933-y.jpg

Furthermore, we have changed the severity to Low, given that in Singapore, those with Chinese names, often have an equivalent English spelling that can be used to replace the Chinese name. This will be more convenient for the doctor as well, since they might not have a separate keyboard with another language installed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The planned enhancement only states that the developer is planning to check and warn the user about incorrect symbols, and notify them on what the correct symbols should be.

It states nothing regarding the acceptance of these valid symbols. Hence, the bug should not be rejected.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** I agree that there is a possible work around to using the English transliteration of such names as a placeholder. However, it would still cause an inconvience if the user wishes to add in the full names of their patients. Therefore I would suggest this bug should be of Medium severity instead.