search

lsds / sgx-lkl

SGX-LKL Library OS for running Linux applications inside of Intel SGX enclaves
MIT License
257 stars 89 forks source link

Test samples in CI #231

Open letmaik opened 4 years ago

letmaik commented 4 years ago

Samples are not tested in CI and will inevitable break over time if they are not run manually regularly. They should be tested in CI, which may simply be a crash test.

letmaik commented 4 years ago

Example of where this would have helped: https://github.com/lsds/sgx-lkl/issues/514. We really need to test samples in CI.

wintersteiger commented 4 years ago

+1. I think this should be p0, it's the first thing prospective users will try!

bodzhang commented 4 years ago

Enhancing test coverage with the samples will help to discover bugs and stability issues. I think this issue should stay as P1.

prp commented 4 years ago

The samples almost completely overlap with the existing CI tests.