lsp-plugins / lsp-plugins-para-equalizer

Parameteric equalizer plugin series
GNU Lesser General Public License v3.0
3 stars 2 forks source link

Parametric EQ redesign #3

Open PROPHESSOR opened 11 months ago

PROPHESSOR commented 11 months ago

Image

sadko4u commented 11 months ago

Hello!

Enable FFT by default Pre + Post FFT option

These features already will be available in the upcoming release.

Reasonable gain range by default (not 36 db 🤯) (make a dropdown list like in FabFilte Pro Q3 with 6db, 12db, 24db, 36db options and select 12db by default)

This is not too hard to implement The idea with combo is bad, slider is much more flexible.

Make points bigger

This can be done as an configurable option. All who want points bigger will be able to change it.

Don't hide points of muted filters

This only conforms with the case when there is no panel with all filters listed. Need to explore.

Show the gain near the point

Good proposal, easy to implement.

All other things are related to serious UI changes and there are still things to discuss. Not in the upcoming release.

PROPHESSOR commented 11 months ago

This is not too hard to implement The idea with combo is bad, slider is much more flexible.

Maybe, but it's not so convenient that the slider also changes FFT zoom... And it took me a while to realize that blue thing was a slider Why don't you like the idea with combo? Do you really need smooth max-gain change?..

This can be done as an configurable option. All who want points bigger will be able to change it.

But why aren't they by default? It's about usability on small screens/touchpads/touchscreens If you check other EQs, you will find that these points are much bigger for that reason image image image image

This only conforms with the case when there is no panel with all filters listed. Need to explore.

Yeah and it will be more convenient if you can toggle filters on/off using the points. Because for now you need to find the needed filter on the panel...

All other things are related to serious UI changes and there are still things to discuss. Not in the upcoming release.

In general, I wanted to switch from the FabFilter plugins pack to something open source and with native Linux support. Among the plugins that I found, your project has is the most powerful tools, I was just shocked by their capabilities

But they have a serious problem: when I first opened them, my eyes just ran wild... A bunch of sections with a bunch of knobs each that have the same size... Because of this, it’s difficult to learn how to work with such tools, because sometimes it’s difficult to just find the right knob

For example, the main parameters of a compressor are threshold and level, but in LSP these knobs are no different from all the others, although, in theory, they should be the largest and take user's attention first

In terms of functionality, LSP is superior to many expensive plugin packages, but it is difficult for beginners to use due to the excessively complex UI

If you are interested, I can make a list of what can be improved in terms of the interface to make it more understandable for an untrained user, so that it can be worked with quickly

The same 20% that gives you 80% of the results

sadko4u commented 11 months ago

Maybe, but it's not so convenient that the slider also changes FFT zoom...

In the upcoming release it is also configurable as proposed @bor-T .

But why aren't they by default? It's about usability on small screens/touchpads/touchscreens If you check other EQs, you will find that these points are much bigger for that reason

Because wide dots take too much space on the graph, so I found the best size to work with plugin on PC. Your argument about touchscreens is understandable. And that's why I think it is a customizable option.

If you are interested, I can make a list of what can be improved in terms of the interface to make it more understandable for an untrained user, so that it can be worked with quickly

We can collaborate with @bor-T who is also responsible for the plugin design to find the best UI solutions. So here we're open but not all things can be done immediately.

We have private development chat in Telegram and can invite you if you're interested.

sadko4u commented 11 months ago

Yet more info. Yesterday I verified and implemented almost all mentioned in this post: https://github.com/lsp-plugins/lsp-plugins-para-equalizer/issues/3#issuecomment-1859222629

I think more complicated UI solutions should be discussed and decomposed into separate tasks.

Also please open further discussions here: https://github.com/sadko4u/lsp-plugins/issues

It is common issue tracker for all plugins in the package.

sadko4u commented 11 months ago

Is it a slope parameter? If yes, does it work? I can't see any changes... Also, it's more convenient to use dropdown list for it with short comments for beginners (like white noise/pink noise/etc)

Just press the 'AUTO' button and drag some bell filter.

Do you really need this Balance knob? Or shouldn't it be changed to "Pan"?

No, Balance controls relative level between left and right channel. Pan controls the amount of left channel mixed to right channel and vice verse. This button is useful when you get some loudness differences between left and right channels.

Interpolate FFT output

Yes, it can be done but has some drawbacks:

Why don't you like the idea with combo? Do you really need smooth max-gain change?..

At least it is more flexible. You can just set the desired scale and work with it instead of some restricted and predefined one.

PROPHESSOR commented 11 months ago

Because wide dots take too much space on the graph, so I found the best size to work with plugin on PC. Your argument about touchscreens is understandable. And that's why I think it is a customizable option.

As an option, you can make them stroke (I mean border-only, without the filling)

We have private development chat in Telegram and can invite you if you're interested.

Yeah, I'm interested in the growth of this project and would like to help) I speak English/Russian/Ukrainian

Also please open further discussions here: https://github.com/sadko4u/lsp-plugins/issues It is common issue tracker for all plugins in the package.

Okay

Just press the 'AUTO' button and drag some bell filter.

Oh... I misunderstood it. I thought it's a tilt factor of the EQ Is it implemented?

Yes, it can be done but has some drawbacks:

It can be made configurable

This button is useful when you get some loudness differences between left and right channels.

Is it a common case in EQ? I think it should be done before the EQ, because it's not its responsibility...

Also there's a "Pitch" knob that does something strange... It just moves all filters frequencies... This can be useful for sound synthesis from noises or similar techniques and often exists in some filter plugins but not a common use of an equalizer... Also I think it should be renamed to "Shift" of something like that because "Pitch" is more about transposing the signal and it will likely misunderstood

Or these knobs can be hidden to some optional "Advanced" panel to reduce knobs amount for non-pro users