search

lspitzner / brittany

haskell source code formatter
GNU Affero General Public License v3.0
691 stars 72 forks source link

nondecreasing export list formatting #313

Closed expipiplus1 closed 4 years ago

expipiplus1 commented 4 years ago 
module Foo
  ( bar
  , baz
  )
where

now becomes

module Foo
  ( bar
  , baz
  ) where

Having the where aligned with module is a bit weirdy IMO.

Not sure if my patch is the best way to do this, I wrote it a while ago and have forgotten how much care I put into it.

~Haven't updated the tests yet either, but is this something which would be merged?~

tfausak commented 4 years ago

Looks good to me! I've always wondered by Brittany formats exports lists like this in the first place.

expipiplus1 commented 4 years ago

Is it possible to get this merged, please?

tfausak commented 4 years ago

Sure, I'll go ahead and merge this.

expipiplus1 commented 4 years ago

Thanks!

On Wed, Oct 21, 2020, 4:35 AM Taylor Fausak notifications@github.com wrote:

Merged #313 https://github.com/lspitzner/brittany/pull/313 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lspitzner/brittany/pull/313#event-3900685005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRJXGJWLBBEDSVJBZPQVDSLXYBXANCNFSM4QNTQNOA .