build: remove `vue-router` auto import type & upgrade deps

lstoeferle / vite-vue2-starter

Vite - Vue 2 starter template using composition-api and windiCSS

MIT License

192 stars 36 forks source link

build: remove `vue-router` auto import type & upgrade deps #11

Closed yuler closed 2 years ago

yuler commented 2 years ago

Updates

degrade @vueuse/core to 5.x

From v6.0, VueUse requires vue >= v3.2 or @vue/composition-api >= v1.1

refs: https://vueuse.org/guide/
remove vue-router auto import in vite.config.js

It will auto import useRoute & useRouter, but it doesn't exist in vue-router@3.x
refresh yarn.lock & auto-imports.d.ts

lstoeferle commented 2 years ago

Hey @yuler, good catch with the vue-router auto-imports. But there is one thing I did not get, why you want to degrade @vueuse/core to v5? This project is using @vue/composition-api v1.4 which is meeting the requirements.

Please revert your changes related to @vueuse/core and we can merge your PR :)

yuler commented 2 years ago

@lstoeferle

degrade @vueuse/core to v5.x because I see

From v6.0, VueUse requires vue >= v3.2 or @vue/composition-api >= v1.1

In the official website

yuler commented 2 years ago

Sorry, I misunderstand.

It's or

yuler commented 2 years ago

@lstoeferle

Hi, I backup to @vueuse/core & upgrade @vue/composition-api

lstoeferle commented 2 years ago

Thanks 😉