lstoeferle / vite-vue2-starter

Vite - Vue 2 starter template using composition-api and windiCSS
MIT License
192 stars 36 forks source link

The class of the container that wraps the Feature component is not set correctly #6

Closed AllenHUSH closed 3 years ago

AllenHUSH commented 3 years ago

In the Commits on Mar 27, 2021(7c3c055600d5c43156ae720f0add52a62398791e)

Incorrect spacing between Feature components ( Features.vue ).

      <div class="w-full py-4 pr-4 xs:pl-4 md:w-1/2 lg:w-1/4">
        <Feature
          title="vite-plugin-vue2"
          text="Vue 2 support for Vite"
          url="https://github.com/underfin/vite-plugin-vue2"
        />
      </div>
      <div class="w-full p-4 md:w-1/2 lg:w-1/4">
        <Feature
          title="vite-plugin-components"
          text="On demand components auto importing for Vite"
          url="https://github.com/antfu/vite-plugin-components"
        />
      </div>

I don't know if the author did it on purpose.

I guess I should write it this way——

      <div class="w-full py-4 px-2 xs:pr-4 md:w-1/2 lg:w-1/4">
        <Feature
          title="vite-plugin-vue2"
          text="Vue 2 support for Vite"
          url="https://github.com/underfin/vite-plugin-vue2"
        />
      </div>
      <div class="w-full py-4 px-2 xs:pr-4 md:w-1/2 lg:w-1/4">
        <Feature
          title="vite-plugin-components"
          text="On demand components auto importing for Vite"
          url="https://github.com/antfu/vite-plugin-components"
        />
      </div>
AllenHUSH commented 3 years ago

Comparison before and after modification

截屏2021-04-30 下午1 14 30 截屏2021-04-30 下午1 14 46
lstoeferle commented 3 years ago

Hi @AllenHUSH, thanks for the hint. I will fix the styling soon, unfortunately I did not test it on large screens :)

lstoeferle commented 3 years ago

Should be fixed now :) See this commit