search

lstrojny / functional-php

Primitives for functional programming in PHP
MIT License
1.98k stars 204 forks source link

Add phpstan typing annotations #250

Open KmeCnin opened 1 year ago

KmeCnin commented 1 year ago

Remaining functions not typed with PhpStan (seems not doable with current features):

lstrojny commented 12 months ago

Terrific work, thank you very much. Let me know when you thinking's ready for merge

KmeCnin commented 11 months ago

@lstrojny my work on phpstan support relies on this commit that fixes/simplify some behaviors: https://github.com/lstrojny/functional-php/pull/250/commits/68ad0fd5224ff7e172902ea1da35d269c9addd28. Do you think that you could first merge this commit before I'm proposing mine?

lstrojny commented 11 months ago

Do you think that you could first merge this commit before I'm proposing mine?

The index_of changes would need to be deprecated first. For now why not use a conditional type to express the current behavior?

KmeCnin commented 10 months ago

@lstrojny I guess this work is ready to be merge. I don't see further improvements at the moment. Let me know if it is ok for you.

(I removed the other commit I was previously based on)

KmeCnin commented 5 months ago

Hello @lstrojny! Do you think that we can merge this PR?