search

luau-lang / luau

A fast, small, safe, gradually typed embeddable scripting language derived from Lua
https://luau.org
MIT License
3.95k stars 372 forks source link

Some compiler warnings #1336

Open Ono-Sendai opened 1 month ago

Ono-Sendai commented 1 month ago 
C:\programming\luau\0.627\Compiler\src\Compiler.cpp(2463,52): warning : missing field 'reg' initializer [-Wmissing-field-initializers]
C:\programming\luau\0.627\Compiler\src\Compiler.cpp(2473,54): warning : missing field 'reg' initializer [-Wmissing-field-initializers]

etc. This is with the Clang that ships with VS 2022.

vegorov-rbx commented 1 month ago

You should be able to disable the warning with -Wno-missing-field-initializers or whatever your compiler documentation says on disabling warnings.

Ono-Sendai commented 1 month ago

I would suggest improving the code with a constructor that just takes a single argument that sets the member you want to initialise. I think this would compile without warnings.

vegorov-rbx commented 1 month ago

We do not plan to make that change and will not accept PRs changing this code.

We will disable that warning in the CMake or will accept a PR that disables it.

Ono-Sendai commented 1 month ago

Ok. I don't use the Luau cmake so won't be making that change.

Btw, is there a security contact that isn't hackerone? hackerone signup isn't working properly.
(Nothing pressing, I just want to ask about something security related)

vegorov-rbx commented 1 month ago

Ok. I don't use the Luau cmake so won't be making that change.

We also disable warnings that we don't care about for in Makefile, so the fix will involve both.

Ono-Sendai commented 1 month ago

I don't use the makefile either :)

vegorov-rbx commented 1 month ago

Btw, is there a security contact that isn't hackerone? hackerone signup isn't working properly. (Nothing pressing, I just want to ask about something security related)

HackerOne is the only channel to submit reports for a bug bounty.

If you are not interested in the bug bounty program, you can report an issue on the Roblox Developer Forum as a regular bug report. Steps are explained here: https://devforum.roblox.com/t/how-to-post-a-bug-report/24388 Roblox bug reports support 'private' information section, so you can avoid exposing sensitive issues publicly.

Ono-Sendai commented 1 month ago

I don't want to post on the roblox forums, it's not a roblox-specific thing. I think i'll just make a new post, you can delete it if you want.

vegorov-rbx commented 1 month ago

You can provide a private report here on GitHub at https://github.com/luau-lang/luau/security by clicking 'Report a vulnerability'.