search

luc-ass / homebridge-evohome

Homebridge plugin for Honeywell Evohome
29 stars 16 forks source link

Periodic update modified to update value on current temp and target t… #42

Closed slippyr4 closed 5 years ago

slippyr4 commented 5 years ago

18e4f27 "Remove unnecessary set characteristics on periodic update" removed some characteristic setValue from periodic update which was incorrect, and causes displayed values to invariably be wrong in the Home app, since Home caches values (as does Homebridge).

This adds the necessary updates to current temp, set temp and current/target state so that the information in the Home app is correct, and updates at the frequency set for the periodic update.

Also the logic for Characteristic.CurrentHeatingCoolingState get was wrong; that should show what the heating is actually doing right now - which is in effect, whether there is call for heat. With the previous logic which was duplicating Characteristic.TargetHeatingCoolingState, all zones showed as actively heating in the Home app, even when they had no call for heat.

luc-ass commented 5 years ago

thank you very much! Has it been stable for you so far?

slippyr4 commented 5 years ago

Yes, I’ve had no problems. I’ve been running it since creating this PR

slippyr4 commented 5 years ago

Also I believe this resolves #41

luc-ass commented 5 years ago

I’ll have al look at it on the weekend. Thanks again!

Am 01.11.2018 um 20:15 schrieb slippyr4 notifications@github.com:

Also I believe this resolves #41

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

luc-ass commented 5 years ago

are any changes to the config needed?

slippyr4 commented 5 years ago

No, none

Sent from my iPhone

On 2 Nov 2018, at 18:20, Lucas Gasenzer notifications@github.com wrote:

are any changes to the config needed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

luc-ass commented 5 years ago

it has now been merged and published to NPM.