luc-ass / homebridge-evohome

Homebridge plugin for Honeywell Evohome
29 stars 16 forks source link

Temperature #51

Closed paskovitch closed 4 years ago

paskovitch commented 5 years ago

Why is it that the accessory in the home application shows the temperature only 26 degrees? In reality, there are 27 degrees in the room and the evohome app shows this well.

luc-ass commented 4 years ago

Can you be a bit more specific? Is it a device that you are not aware of? Could it be the controller itself?

paskovitch commented 4 years ago

In the homekit application, the temperature is shown up to 26 degrees by the thermostat supplement. Honeywell Home app normally displays over 26 degrees.

luc-ass commented 4 years ago

Ah, so all the devices are working properly, only the temperature caps at 26 °C? This is probably a hard coded limit. I'll have a look.

luc-ass commented 4 years ago

Got it. index.js lins 642 states that the read temperature maxes out at the maximum setable temperature. Probably due to copy paste during creation of this plugin.

You could change that value to something else (i.e. 50 or so) and then test it. If it works I would be most happy to implement it in the live version.

paskovitch commented 4 years ago

It works, thank you!

luc-ass commented 4 years ago

Great. Can you provide me wit the exact line that is working? I’ll change it in the repo and upload the fix to NPM.

paskovitch commented 4 years ago

.setProps({ minValue: 1, maxValue: 50, minStep: this.device.valueResolution });

luc-ass commented 4 years ago

Thanks. I’ll update it in the coming days.

luc-ass commented 4 years ago

Okay. It's now published on NPM. Thanks for your input!