search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.78k stars 465 forks source link

Cybersec + build process #777

Closed atsju closed 2 years ago

atsju commented 2 years ago

Mention #737

@luc-github some questions:

luc-github commented 2 years ago

Something to add about cybersec ?

Not sure what is necessary to add

I propose to replace the ESPtool section to use Arduino or platformIO instead. Both are able to fully erase memory. What do you think ?

I am ok with that it is old - at this time no such feature in Arduino IDE

Is it OK to say platformIO is "recommended method" for build ?

Yes sure

atsju commented 2 years ago

@luc-github I double checked est PlatformIO doesn't offer erase flash for ESP8266 (only for ESP32) It's even worse because ESP8266 doesn't erase fully with upload from platformIO. I experienced some problems...

One more question: is it enough to do [ESP444]RESET to ensure flash is clean (even if not fully erased)?

luc-github commented 2 years ago

the erase flash in PIO depend of version used for 2.1 there is one entry which has it, in 3.0 all entries have it image

[ESP444]RESET will only clean the EEPROM area and set clean values for ESP3D [ESP710]FORMAT will Format FS, in case of corrupted SPIFFS for example

atsju commented 2 years ago

I have been too fast I will update with ESP710. Thanks

I opened an issue here about erase: https://github.com/platformio/platform-espressif8266/issues/276 but it doesn't seem to be very active. You are right it depends of the version. strange it's not documented there

atsju commented 2 years ago

@luc-github Please note this PR is ready for review (no urgence)

luc-github commented 2 years ago

Looks Ok for me - thanks a lot ^_^

luc-github commented 1 year ago

@all-contributors please add @atsju for documentation update

allcontributors[bot] commented 1 year ago

@luc-github

I've put up a pull request to add @atsju! :tada: