[Feature Request]ESP700 does not handle comments

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer

GNU General Public License v3.0

1.78k stars 465 forks source link

[Feature Request]ESP700 does not handle comments #785

Closed luc-github closed 2 years ago

luc-github commented 2 years ago

; is usually used to comment GCODE files it can be at start of line or at end of GCODE command

;change layer
G1 Z1.2 F300 ;new layer

Currently [ESP700] using gcode stream host processing task just read line and send it, it would be good to save some data bandwidth, to clear the comments as I do not think they are used by FW (TBC)

luc-github commented 2 years ago

Actually it does https://github.com/luc-github/ESP3D/blob/3.0/esp3d/src/modules/gcode_host/gcode_host.cpp#L296-L307 I do not know why I forget it orz...

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.