search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.78k stars 465 forks source link

[Question] [ESP3D v3] Hide notifications #973

Closed dbuezas closed 11 months ago

dbuezas commented 11 months ago

Is there any way to not display these notifications?

image

It seems like these aren't hidden if the tab is not in the foreground for a while so they also accumulate.

luc-github commented 11 months ago

they should hide after a while but I think they are meaningless they should not be send if they are using HOMEASSITANT I think same for display: Check here : https://github.com/luc-github/ESP3D/blob/3.0/esp3d/src/modules/notifications/notifications_service.cpp#L188-L196

dbuezas commented 11 months ago

It looks like there is a bug on top of that. If I leave the tab in the background they accumulate and only the last one is removed:

image
luc-github commented 11 months ago

what do you mean by tab in background ?

dbuezas commented 11 months ago

For example if you have 2 tabs open in your browser, one is ESP3D and the other is youtube, but you are watching youtube so the ESP3d is "in the background", or inactive

dbuezas commented 11 months ago

I opened a PR https://github.com/luc-github/ESP3D-WEBUI/pull/375

github-actions[bot] commented 11 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.