search

lucacasonato / deno-puppeteer

A port of puppeteer running on Deno
https://deno.land/x/puppeteer
MIT License
454 stars 44 forks source link

Don't replace `Node` and `Element` types with `any` #61

Open jespertheend opened 2 years ago

jespertheend commented 2 years ago

I'm not sure what the reason was to remove Element and Node types, so this PR might be uncalled for. My projects already have "dom" added to the compilerOptions so I needed this anyway, so I figured I might as well submit a PR.

I reckon any project using puppeteer will benefit from adding dom types to the compiler options anyway, and deno doesn't type check remote modules in deno run by default since 1.22. So I don't think there should be any issues in bringing these types back.

Fixes #54