search

lucacasonato / esbuild_deno_loader

Deno module resolution for `esbuild`
https://deno.land/x/esbuild_deno_loader
MIT License
162 stars 43 forks source link

chore: bump dependencies #78

Closed deer closed 1 year ago

deer commented 1 year ago

I tried fixing https://github.com/denoland/fresh/issues/1421 by increasing the version to 0.18.15, but I was getting a type error complaining about 0.17.19. I see we're still using that here, so I thought I'd increase the versions here.

deer commented 1 year ago

@lucacasonato, what do you think about this?

deer commented 1 year ago

@lucacasonato, any thoughts? You can close this or start the tests to make me go away, otherwise I'll continue with my exponential backoff and try again in four weeks.

AlexJeffcott commented 1 year ago

If I want to use the X version of esbuild in my project, I may not be able to as the imported types for esbuild within this project appear to be pinned to a specific version.

I wonder whether it would make sense to use the types that come with the version of esbuild that is ‘installed’ by the user?

In this way, the user will be able to see whether there is some genuine problem with the Plugin type (like the provided plugins are in some way not compatible with that version of esbuild). If that is the case, then users could deal with this problem directly.

What do you think?