search

lucagrippa / obsidian-ai-tagger

Simplify tagging in Obsidian. Instantly analyze and tag your document with one click for efficient note organization. OpenAI or MistralAI API key required
MIT License
27 stars 5 forks source link

Current version always creates "null" tag #4

Closed ianTevesAcc closed 1 month ago

ianTevesAcc commented 2 months ago

As the title says the current plugin version generates "null" as a tag.

lucagrippa commented 2 months ago

Hi @ianTevesAcc are you still having this issue?

When it generates "null" as a tag is that in addition to other tags? Example output: "#tag1 #tag2 #null"

Or is it not returning any tags and only returning "null"?

Or some other variation perhaps. Any further details you could provide would be very helpful! Feel free to also add a screenshot or video if you have one.

ianTevesAcc commented 2 months ago

Yes unfortunately. The AI tagger works well and gives proper tags relative to the current note but a null tag is always generated first before adding other tags.

This img shows tags being created but "null" being added first before the actual tags relative to the note. It's easy to work around; you just have to remove the null tag every time the AI Tagger is run. I just wanted to let you know. image

lucagrippa commented 2 months ago

Hi @ianTevesAcc I just released a new version of the plugin that should fix this issue. Let me know if the fix is not working. If you come across more bugs or if you want to request features feel free to open another issue.

ianTevesAcc commented 2 months ago

It's weird. For some reason it cant detect the AI Model now in the updated version.

I just updated and gave it a new open ai api key and set the Model to be OpenAI GPT-3.4 Turbo. It gave me this error. Is this happening on your end? @lucagrippa

plugin:terminal:115 Error while generating tags: Error: Error getting model. at getLlm (plugin:ai-tagger:24585:11) at Object.editorCallback (plugin:ai-tagger:24658:21) at e.mobileOnly.zt.isMobile.e.checkCallback (app.js:1:1988281) at oK (app.js:1:1987579) at e.executeCommand (app.js:1:1989143) at e.onTrigger (app.js:1:1164833) at e.handleKey (app.js:1:757237) at e.handleKey (app.js:1:757350) at t.handleKey (app.js:1:757559) at e.onKeyEvent (app.js:1:758493)
eval @ plugin:terminal:115
c @ plugin:terminal:111
editorCallback @ plugin:ai-tagger:24671
e.mobileOnly.zt.isMobile.e.checkCallback @ app.js:1
oK @ app.js:
e.executeCommand @ app.js:1
e.onTrigger @ app.js:1
e.handleKey @ app.js:1
e.handleKey @ app.js:1
t.handleKey @ app.js:1
e.onKeyEvent @ app.js:1
ianTevesAcc commented 2 months ago

I switched back to vers 1.0.4 The plugin works here as well as the null bug not being present.

lucagrippa commented 1 month ago

I just pushed another release, 1.1.4. This should fix that "Error getting model" bug that was present. Thank you for working with me to fix this, I really appreciate it!

ianTevesAcc commented 1 month ago

Awesome!