search

lucanaef / PGPro

OpenPGP En- & Decryption App for iOS
https://pgpro.app
GNU General Public License v3.0
375 stars 33 forks source link

Create CI/CD Pipeline #113

Open haraldhob opened 1 year ago

haraldhob commented 1 year ago

Hello @lucanaef,

we are two students from KTH Stockholm and are participating in a DevOps course. One of our assignments is a DevOps related contribution in an open source project. We would like to participate in PGPro and propose to develop a CI/CD pipeline with the following content:

Would you be interested in such a contribution? Thank you in advance for your answer!

lucanaef commented 1 year ago

Sure, sounds great!

haraldhob commented 1 year ago

WIP Update: We will start working now on creating the CI/CD Pipeline. We will create a fork and work on a separate branch there to create a pull request. First tasks will be building the swift project and running tests.

luisjira commented 1 year ago

@lucanaef we're currently working on the deployment to the AppStore. Do you want this to happen on every push to the master branch or on a new release tag? The current deployment workflow is defined here: https://github.com/haraldhob/PGPro/blob/feature/cicd/.github/workflows/deployment.yml

We also noticed that the develop branch is more active at the moment. Which branch would you prefer us to open a pull request for?

lucanaef commented 1 year ago

I'd say on a new release tag. Please open the pull request to develop, I'll then merge it into main later.

luisjira commented 1 year ago

Okay, I just changed the workflow trigger to a "released" release tag.

Currently, we also have a workflow configured to release a beta version to TestFlight on every push to develop. Would you prefer this to trigger on a "prereleased" release tag?

A release tag with the action type "prereleased" is defined here as:

A release was created and identified as a pre-release. A pre-release is a release that is not ready for production and may be unstable.

lucanaef commented 1 year ago

I like your current workflow configuration with tags for releases and continuous beta builds on pushes to develop.

luisjira commented 1 year ago

We have now created #118 for you to review our changes.