Support `--envfile` CLI argument

lucaslorentz / caddy-docker-proxy

Caddy as a reverse proxy for Docker

MIT License

2.61k stars 163 forks source link

Closed thekondor closed 7 months ago

thekondor commented 7 months ago

Addresses #423:

To stay consistent with caddy, the argument's name is --envfile.
godotenv library is used to parse & load envfile (was: ~Since caddy doesn't expose API for loading environment files, a corresponding code was borrowed with a copyright note.~)

francislavoie commented 7 months ago

Why is this necessary? You can load the env from file with Docker Compose already.

thekondor commented 7 months ago

Why is this necessary? You can load the env from file with Docker Compose already.

423 states exactly the use-case - to prevent leaking the secrets set through environment variables to metadata (docker inspect). env_file in a compose file exposes variables to a container's metadata anyway.
docker-compose is not the only must-be-used-way to run caddy-docker-proxy (given that docker-compose is able to inject environment variables w/o publishing them to the metadata).

francislavoie commented 7 months ago

https://github.com/joho/godotenv could be used instead of copying Caddy's impl.

We originally wrote our own to keep things simple but it already grew a bit since. I'm considering switching to a lib at some point in the future

lucaslorentz commented 7 months ago

Code LGTM. Requested a minor change to the log message, will give you some time to adjust it before I merge.

lucaslorentz commented 7 months ago

Merged, will do a new release in case you would like to use it from official docker images.