lucazdev189
commented
2 months ago gee, thanks for your advice! will make sure to update my code.
Open dmi3kno opened 2 months ago
lucazdev189
commented
2 months ago gee, thanks for your advice! will make sure to update my code.
Read your story on Reddit. Congrats and excellent job! Very happy about your interest in R. And congrats on your package!!
Some thoughts with regards to your intention to put this package on CRAN
CRAN people will complain about this. They will recommend you allocate temporary file and write to it and return path to the user. I corrected my package in response to CRAN comments to look like this
It might be a good idea to think of memoisation, authentication (user-agent string) and rate-limiting. Even though it seems like you are not scraping anything that is explicitly disallowed, it might be a good idea to check before you attempt to scrape
The owners of the website might impose further restrictions to those specified in robotstxt today
Let me know if you need help!
PS: shameless advertizing: have a look at my package which offers some code templates for scraping. Slides, video