lucianodato / noise-repellent

Lv2 suite of plugins for broadband noise reduction
GNU Lesser General Public License v3.0
455 stars 38 forks source link

Development #118

Open Efenstor opened 11 months ago

Efenstor commented 11 months ago

Fixed broken state saving for the stereo mode: strcmp returns zero if matches, strstr returns pointer; replaced everything with strcmp as less ambiguous. Spent several hours trying to identify why soft-bypass works for the mono version and ignored in stereo, it seems that it is because input=output for some reason. Finally thrown a towel and added a crude fix (tested in Ardour 7.5). At least now the plugin is fully-functional. Not sure about what "units:conversion" line does but added it to nrepellent.ttl because it was in all the other files. Optimized some redundant code (for example removed the connect_port_stereo function), probably it all was there as the placeholder for the further development, I dunno.

In theory a new release can be made.