search

luckyframework / authentic

An authentication library for Lucky projects
MIT License
14 stars 13 forks source link

Optimize dockerfile #39

Closed robbyoconnor closed 3 years ago

robbyoconnor commented 4 years ago

Remove packages which exist in the base image to speed up build; and move WORKDIR to the top to avoid cache invalidation; also COPY over ADD.

Fixes #40

stephendolan commented 3 years ago

@jwoertink it looks as though most of this has been taken into account in the current Dockerfile, thoughts on closing this one out?

jwoertink commented 3 years ago

Yeah, we can close this out. It's pretty outdated now, and I don't use Docker when running avram spec locally. I remember @robbyoconnor did some other optimizations though that we did take, so if you wanted to give it another shot @stephendolan feel free.