search

luckyframework / authentic

An authentication library for Lucky projects
MIT License
14 stars 13 forks source link

Use Habitat for setting validation #61

Closed jwoertink closed 3 years ago

jwoertink commented 3 years ago

https://github.com/luckyframework/authentic/blob/110d4291362eec24e86094846c3eb0a12717f674/src/authentic.cr#L148-L150

This method is basically doing validation to ensure that the secret key is 32 characters long, but we can move that logic in to Habitat itself https://github.com/luckyframework/habitat#setting-validations

jwoertink commented 3 years ago

LOL 🤣 ok, so String doesn't have a length method... This shouldn't compile, but the reason it does is because this method is never called...