search

ludo / react-native-torch

Torch (flashlight) plugin for React Native (Android/iOS)
MIT License
78 stars 27 forks source link

1.1.1: Update entry point | Make alert un-cancelable #4

Closed dac09 closed 6 years ago

dac09 commented 6 years ago
dac09 commented 6 years ago

@ludo any chance you could review please? I'm ready to make changes if required.

ludo commented 6 years ago

Tested locally (with npm link): works! I'll publish v1.1.1 to npm as @next and test again.

dac09 commented 6 years ago

Out of curiousity, does npm link work for you when you use android studio? I get gradle errors - it seems to not like symlinks. I've found command line to be okay with it though.

ludo commented 6 years ago

@dac09 I haven't tried inside Android Studio, I'm using it on the command line. But even there it doesn't work out of the box... I have to use a script I found in facebook/metro#1 to get it to work 😑