ludofleury / GuzzleBundle

Debug your API Calls with a Symfony web profiler for guzzle
http://ludofleury.github.io/GuzzleBundle/
MIT License
82 stars 21 forks source link

"<strong>" appears in response tab #19

Closed agallou closed 10 years ago

agallou commented 10 years ago

Here is how the set-cookie is displayed when there is more than one value :

profiler - 2013-12-18_09 01 50

(<strong>, </strong> is showned in the profiler ).

In the response.html.twig, the value is displayed like that :

                <td>
                    {{ value|join('<strong>, </strong>') }}
                </td>

Should it be something like that ?

                <td>
                    <strong>
                    {{ value|join('</strong>, <strong>')|raw }}
                    </strong>
                </td>

Or does the strong should be removed ?

ludofleury commented 10 years ago

Oh good catch here. It should be removed.

Ludovic Fleury Paris, France.

+33 (0)6 18 50 47 24

Get some IT / Devops news on twitter: @ludofleury Watch my open-source contributions on github: ludofleury Read feedback about my experiences: http://testonsteroid.tumblr.com

On Dec 18, 2013 9:06 AM, "Adrien Gallou" notifications@github.com wrote:

Here is how the set-cookie is displayed when there is more than one value :

[image: profiler - 2013-12-18_09 01 50]https://f.cloud.github.com/assets/320372/1771540/c6cb37a2-67ba-11e3-916d-af5a35b1e1c5.png

(, is showned in the profiler ).

In the response.html.twig, the value is displayed like that :

            <td>
                {{ value|join('<strong>, </strong>') }}
            </td>

Should it be something like that ?

            <td>
                <strong>
                {{ value|join('</strong>, <strong>')|raw }}
                </strong>
            </td>

Or does the strong should be removed ?

— Reply to this email directly or view it on GitHubhttps://github.com/ludofleury/GuzzleBundle/issues/19 .

agallou commented 10 years ago

ok. I will make a PR.

agallou commented 10 years ago

Done in PR #20