luisgoncalves / xades4j

A Java library for XAdES signature services
GNU Lesser General Public License v3.0
111 stars 66 forks source link

Bump dependencies because of several CVEs #274

Closed mjechow closed 1 year ago

luisgoncalves commented 1 year ago

Thanks for this!

Can you please rebase? I've update a missing CRL to fix tests.

Also tried building, javadocs and tests locally. Looks good.

mjechow commented 1 year ago

Thanks. I hope the bumps of dependencies like gpg-plugin work. I cannot test them.

Furthermore, I saw some remarks by SonarLint. I you don't mind, I will refactor some parts of code time by time. Is it planned to switch to JUnit5?

Also Guice 7.0.0 is released with a slightly different api. Time will come, when xades4j needs to be updated.

mjechow commented 1 year ago

Again, I did't rebase but merge. Sorry. I am not used to the gitHub GUI. :-(

luisgoncalves commented 1 year ago

Right, I'll test those when preparing another release.

Sure, feel free to submit PRs :) I'll attend to them as time allows. Most of the library was written 10+ years ago; the language evolved a lot since then.

Regarding Junit5, I actually started upgrading. I'll try to pick up on that again soon.