lukas-w / font-logos

An icon font providing popular linux distro's logos
https://lukas-w.github.io/font-logos
The Unlicense
446 stars 85 forks source link

Add logos from window managers. #105

Closed hasecilu closed 1 year ago

hasecilu commented 1 year ago

readme-header

hasecilu commented 1 year ago

I agree with the cleanup.

Finii commented 1 year ago

preparing merge

hasecilu commented 1 year ago

I updated the database with the offset needed for #103 , didn't update the README to avoid more conflicts.

Finii commented 1 year ago

I updated the database with the offset needed for #103 , didn't update the README to avoid more conflicts.

Hmm?

I force pushed because rebase on master.

...

Finii commented 1 year ago

Can not undo my force push because did not pull directly in front of it.

What do we do now? Assigning codepoints can only be done directly before merging. Sorry. You need to push your changes back in.

hasecilu commented 1 year ago

I also force pushed rebase on master but in #103, I put #103 before this PR, I'll let you choose the codepoints to avoid conflicts

hasecilu commented 1 year ago

Ok let's leave this PR as of now and I'll start #103 on 95

Finii commented 1 year ago

I would merge and only afterwards go to the next PR, in that way you can rebase on master there and allocate the codepoints... and then merge, etc ;-)

But anyhow, I guess you prepare all "ready" PRs with codepoints now and they will only work if pulled in sequence I guess.

You prepare and then pull these three now?

Finii commented 1 year ago

I also force pushed rebase on master but in #103, I put #103 before this PR, I'll let you choose the codepoints to avoid conflicts

Laugh ... well, I have no clue we can not work in parallel ;-)

I guess you can allocate codepoints and merge the three PRs? Possibly after considering changes suggested ;)

hasecilu commented 1 year ago

I was planning on merge first 103 then 104105, ...

hasecilu commented 1 year ago

I'll start here