lukas-w / font-logos

An icon font providing popular linux distro's logos
https://lukas-w.github.io/font-logos
The Unlicense
446 stars 85 forks source link

Problem with Krita icon #113

Closed hasecilu closed 1 year ago

hasecilu commented 1 year ago

Krita logo have some artifacts in the header.

image

I generated the header in my machine and it's ok, also checked the font and it's ok too.

image

hasecilu commented 1 year ago

Intersection in the brush: image

hasecilu commented 1 year ago

Extra nodes (bottom left): image

Finii commented 1 year ago

And I already pushed to NPM :grimacing:

https://npmfs.com/package/font-logos/

It's also in the font:

image

hasecilu commented 1 year ago

I opened the ttf font from the GitHub release and have the artifact

image

Finii commented 1 year ago

I'm fighting with inkscape right now, am used to work in Glyphs and need to find out how to remove the handle :-D

hasecilu commented 1 year ago

I pushed to master an update, let's see if that fixes the problem Edit: header remains the same

Finii commented 1 year ago

I can fix that, or do you want to fix that, I always am confused.

hasecilu commented 1 year ago

I removed the intersection but that didn't resolve the problem, did you find another problematic node? I'll let you fix it

Finii commented 1 year ago

Are the more bugs or is it time for 1.1.1 ;-)

Finii commented 1 year ago

Fixed problems here, iirc:

image

hasecilu commented 1 year ago

I'm looking at the new logos but still don't find anything odd. If you want to 1.1.1 is ok, (always could be an 1.1.2)

Finii commented 1 year ago

I guess I need to be more thorough...

image Tip of the brush stroke in the left of the icon

Finii commented 1 year ago

Found more issues ... prepared the new svg

image

Finii commented 1 year ago

Ah the reason that local and workflow differ is that different fontforge versions are used.

image

At least I guess you use (as I do) Fontforge 20230101 ? In fact I usually use a self-build Fontforge with some patches in. If you also use a newer version I will change the workflow to use a newer fontforge to prevent unexpected surprises. (Hmm, are there expected surprises? ;-)

Fontforge is two revisions ahead of the default workflow version. At NerdFont I learned that one always needs to use the latest ff release as there really are bugs fixed.

image

So, please tell me your libfontforge version? (apt show python3-fontforge)

hasecilu commented 1 year ago

I use this version that dates from April, maybe I should start using fontforge-git

paru -Qi fontforge                                                                                            
Name            : fontforge
Version         : 20230101-3
Description     : Outline and bitmap font editor
...
Build Date      : 2023年04月07日 00時26分40秒
Finii commented 1 year ago

Well, there is no newer release than 2023-01-01, but you use that already.

Now the workflow uses that fontforge. All the workflow snippets are taken from Nerd Fonts.