search

lukas-w / font-logos

An icon font providing popular linux distro's logos
https://lukas-w.github.io/font-logos
The Unlicense
446 stars 85 forks source link

Add Nobara Linux logo #143

Closed hasecilu closed 3 weeks ago

hasecilu commented 2 months ago

Let's see if there is interest for this. https://nobaraproject.org/download-nobara/ https://github.com/Nobara-Project/nobara-images

Finii commented 2 months ago

Technically there seem to be some problems.

For example note the 'path direction' indicators that I labelled with arrows. The direction changes in the middle?! The problem is that there are 2 points where it looks like one point. Multiple instances of these (some marked with circles).

A quick 'simplify' run in Inkscape fixes it (did not check if there are more problems). Otoh the simplify run kind of breaks the sharp tip in the middle-bottom *sigh*

image As in the PR

image Direction indicators bigger

image Simplify fixes most but raises new problems ;)

Finii commented 2 months ago

fontforge does a simplification on import also, and most problems vanish then.

But here for example the tripple points make the resulting glyph needlessly complicated and they are not removed automatically.

image Should probably be smooth instead

We use this fontforge function to import the svgs, note the default that simplify away the double points if they are close enough to each other:

image

image

hasecilu commented 2 months ago

I tried to simplify a little and got 26 nodes, what do you think? image

image

Finii commented 2 months ago

Great! Thank you!

If we look really really close (which I usually do NOT, so again, this does not need to be changed I guess), we can see some problem with these two points (see the problems from the images you shared above):

image

image

The handles of the upper point have less then 180 degrees on the upper side; that means that the outline will be convex there. This can be changed if the node is set to 'smooth'.

One handle of the lower point is below the point. That means we have a very very thin outline there below the point; and that point is not on the extremes. This can be changed if that node is set to 'corner' or the handle length set to zero.

In the fontforge view you see how the "problems" converted:

image

The upper point is now represented by two nodes because fontforge wants to use joined control points and this is the only way to represent the convex structure (because we have now truetype outlines).

image

The lower point problem is repaired by the simplify fontforge runs automagically.

Finii commented 3 weeks ago

Ah this fixes #121.