lukas-w / font-logos

An icon font providing popular linux distro's logos
https://lukas-w.github.io/font-logos
The Unlicense
446 stars 85 forks source link

Add River icon #144

Closed hasecilu closed 3 weeks ago

hasecilu commented 2 months ago

A dynamic tiling Wayland compositor https://isaacfreund.com/software/river/ https://codeberg.org/river/river Licence: GPL-3.0-or-later

Finii commented 2 months ago

Nodes look excellent, all path closed (that turned up elsewhere again)

image

Only thing that makes me raise my eyebrows in question... There is quite some padding top/left/bottom/right. With most icons we keep that to zero or at least minimal. The only exceptions (icons with some padding, like River above)

image How other icons fill their 'cells'

Edit:

It might be that the padding is intentional. But I wanted to raise that question.

hasecilu commented 2 months ago

The padding was not planned, now it fills the space.

image

hasecilu commented 2 months ago
  • Alpine
  • gtk
  • openscad

The nodes/edges of these are already touching the canvas edge, unless we want to go bigger and cross the canvas boundary as in Kali Linux. Also dwm, XFCE look small.

Finii commented 2 months ago

You are right, I do not know what I saw :thinking:

Except for openscad

image

Some more like XFCE have a less pronounced border.

The "problem" is that we first scale the svg into the font 'cell' and then we remove the borders / bearing; this means that the advance width will be smaller, not that the icon gets bigger.

Anyhow :-)

Finii commented 3 weeks ago

Hej @hasecilu

I will merge this now. What about Nobara, there were no comments, no thumbsups, merge or not merge?

I ask because I would like to release a new Font Logos version, what do you think? (Because Nerd Fonts' release is overdue already)

Finii commented 3 weeks ago

I ask because I would like to release a new Font Logos version, what do you think?

Just released :grimacing: Hope this is ok for you, if not we can of course do some amends.

Interestingly most npm people seem to use the very old version, note this is last 7 days stats:

image

hasecilu commented 3 weeks ago

Of course is totally OK.

Maybe was marked as dependency with that tag version?