Closed Finii closed 2 years ago
Just noticed that we can also move Alma Linux around, if we say v0.18 is a buggy release (with wrong codepoints), because it did not exists in v0.17 either.
This results in this nicely packed font for v0.18.1 / v.019:
Also changed the glyph.json
to be (automagically) sorted by codepoint which makes handling easier I believe:
{
"alpine": {
"codepoint": 61696,
"source": "vectors/alpine.svg"
},
"aosc": {
"codepoint": 61697,
"source": "vectors/aosc.svg"
},
"apple": {
"codepoint": 61698,
"source": "vectors/apple.svg"
},
"archlinux": {
"codepoint": 61699,
"source": "vectors/archlinux.svg"
},
["..."]
"rocky-linux": {
"codepoint": 61737,
"source": "vectors/rocky-linux.svg"
},
"almalinux": {
"codepoint": 61738,
"source": "vectors/almalinux.svg"
},
"pop-os": {
"codepoint": 61739,
"source": "vectors/pop-os.svg"
},
"artix": {
"codepoint": 61740,
"source": "vectors/artix.svg"
},
"kali-linux": {
"codepoint": 61741,
"source": "vectors/kali-linux.svg"
}
}
Sorry, wrong force push, reverted it.
Superseded by 34043a8 as explained in https://github.com/lukas-w/font-logos/issues/72#issuecomment-1175210783. Thank you @Finii.
[why] When codepoints are changed for the individual logos that should be a deliberate decision.
[how] We have now a dedicated file for the codepoint to logo mapping. That will be used for the font generation:
glyphs.json
.If new logos show up or exisiting ones are deleted this will change that dedicated file when
compile.sh
is called and what happened is clearly visible in the changed git status.People who add / remove a logo have to run
compile.sh
and afterwards review the changes in theglyphs.json
file and include that changes in their commit.[note] This is only slightly different to the formerly used solution: Keep the
.fontcustom-manifest.json
in git. But that has been removed with commit f161cf6 for some reason. Maybe because that file is hidden, which is not so nice.This PR just preserves the "glyphs" section of the manifest and extracts it into a dedicated file, that can be added and reviewed.
[note] Glyph codepoints reverted back to
f161cf6^
i.e. 12f3783 (a.k.a. v0.17)Fixes #33 Fixes #72
After pulling this we would need a new release, either 0.18.1 or 0.19 or something.
Here the (new) codepoint allocation: