search

lukash / refloat

VESC package for self-balancing skateboards.
GNU General Public License v3.0
20 stars 14 forks source link

AppUI View truncated on square aspect ratios #15

Open NicoAleman opened 2 months ago

NicoAleman commented 2 months ago

Screenshot captured on Galaxy Z Fold 6. Having scrollable when the content doesn't fill the screen (if possible with QML) is a potential solution

received_1253687365636061

lukash commented 2 months ago

Having scrollable when the content doesn't fill the screen (if possible with QML) is a potential solution

From what I remember this is a bit tricky, I'd rather like to avoid scrollable if possible. It's also a rather poor UX.

I'll see if I can think of something. Not super high priority though. (If anyone would want to tackle this, get in touch to discuss ideas)

NicoAleman commented 2 months ago

Definitely not high priority, that's why I posted the issue, since I'd inevitably forget 🤣

outlandnish commented 1 month ago

I don't know much about VESC development, but happy to look into this. This would be nice on the smaller screen on a Razr as well.

lukash commented 4 weeks ago

@outlandnish thanks for the offer! I'm afraid this won't be easy though. It's not much about VESC development, the UI is in QML. I think some experience with QML is desirable while tackling this, otherwise you'll probably be struggling. There's an added complication here that the whole UI needs to be a single file, which is now already 3500 lines long. The change needs to be done in a very clever way to not add much complexity and not duplicate any code, because otherwise it'll end up being a nightmare to maintain.

My idea was to alter the layouts depending on the aspect ratio of the display. But just having a quick look now (it's been a while I wrote the UI), it seems like it's not possible in a trivial way. There may be some clever trick to use or this may just not be feasible...