lukasmalkmus / rpi_exporter

A Raspberry Pi CPU temperature exporter.
Apache License 2.0
79 stars 17 forks source link

Add a simple healthcheck #16

Closed aalaesar closed 3 years ago

aalaesar commented 3 years ago

A simple PR to fix a Monitoring problem in a pi kubernetes cluster:

Issue: Using rpi_exporter as arm_exporter behind the kube-rbac-proxy doesn't allow to use a liveness probe on the rbac-proxy.
because the liveness probe doesn't support rbac authentication.

Solution: Adding a basic /health endpoint on the rpi_exporter allow the use of liveness probes by white-listing the /health endpoint on the rbac-proxy, allowing the use of liveness probe through the proxy without authentication.

lukasmalkmus commented 3 years ago

LGTM, will cut a release. @carlosedp can you push new docker images as soon as I tag v0.7.0?

carlosedp commented 3 years ago

Yes, sure... ping me once it's released and I'll trigger the image build.

lukasmalkmus commented 3 years ago

Done @carlosedp !

carlosedp commented 3 years ago

Pushed, let me know any issues... due to Travis-ci migration I had to build it manually.

carlosedp commented 3 years ago

I borked the initial push (container had x86 binary). Last push fixes it, sorry.