search

lukechurch / dynamo-integration-example

Location for the Dynamo Integration Guide examples
MIT License
0 stars 1 forks source link

updated sample #1

Open eertugrul opened 9 years ago

eertugrul commented 9 years ago

@lukechurch I was following this guide https://github.com/DynamoDS/Dynamo/wiki/Integration-Guide, and didnot see any behavioral differences between Hog and TracedHog as described in the guide. TraceHog ID should return 0, every time move the slider should return the original Tracehog instead creating a new one,

image

Also I tried to delete the node and dragged in back to dynamo canvas, but the id numbers incremented from the where there were before instead starting 0. I tried to add IDisposable but I couldn't make it work.

I was wondering if u have updated version of the dynamo-integration-example ? Thank you

lukechurch commented 9 years ago

Hey @eertugrul

Sorry about this - I've moved this into the main repo, and yes, I'll get the bug fixed. ASAP.

Samples are now here: https://github.com/DynamoDS/Dynamo/tree/master/src/Libraries/Samples

They currently still have the bug.

Sorry for the confusion

lukechurch commented 9 years ago

Hi @eertugrul

I think this fixes the issue: https://github.com/DynamoDS/Dynamo/pull/3526

We were missing the line that writes into the TLS store.

Improved documentation to follow. Please let me know if you have any questions, and thanks for your patience.

Luke

eertugrul commented 9 years ago

@lukechurch Thank you for the update. I have just been able to run a test.

I have added one minor addition to the sample, now the inputs are not reflected the changes of dynamo node's inputs. I would pass the input x and y values back to the tracedhog after the line below so we can update the X, Y properties of the object.

just under this line, https://github.com/DynamoDS/Dynamo/blame/master/src/Libraries/Samples/SampleIntegration/TracedHog.cs#L110 tHog.X = x; tHog.Y = y;

Thank you, Can't wait to implement to our custom nodes.