search

lukecyca / pyzabbix

Python Zabbix API
977 stars 315 forks source link

Do not reveal password in error message upon connection issue #161

Open krisavi opened 2 years ago

krisavi commented 2 years ago

Would be nice if the password is not shown in the error message if there is issues connecting to zabbix.

For me the API is used to build json output for external contact to monitor as guest and when there was issue with connecting to Zabbix, it screamed it into the output that ended up revealing zabbix password to public. I did change the password, so it is all good on that end, but would be nice if it does not print out plaintext password or access token upon connection error in the future. I do not think it is information that helps with debugging issues, it would be ok if the password or access token is replaced with "*".

szuro commented 2 years ago

Can you provide a code sample for this?