search

lukeweber / webrtc-jingle-client

Webrtc audio + jingle protocol brought to IOS and Android.
https://groups.google.com/forum/?fromgroups#!forum/webrtc-jingle
BSD 3-Clause "New" or "Revised" License
335 stars 137 forks source link

IOS example app #51

Open lukeweber opened 11 years ago

lukeweber commented 11 years ago

Can anyone do a better IOS app than this?

iOS Simulator Screen shot Dec 17 2012 9 11 23 PM

I've done a base wiring, but I'm not IPhone dev, and would appreciate any help anyone could provide.

Would be nice if we did some basic UI like we have on android:

This should allow us to do more testing on IPhone easily to nail down any issues we might have with the library.

jlavyan commented 11 years ago

Hi i want help with this issue

login screen buddy list / call a user in the list in call UI (end call, mute, hold) incoming call notification UI (pop up/notification).

what you think, only those simple screen is needed ?

lukeweber commented 11 years ago

That would be awesome. As you can see, current app needs a bit of work :)

@hailg is currently working on https://github.com/lukeweber/webrtc-jingle-client/issues/69 and had mentioned interest in building some UI. His ticket shouldn't impact you per se as his work should ideally be a unique target and way to use the core library. Then again, if XmppFramework is working well, it might be the most suitable platform for building an app on iOS.

Maybe hai can update us on his status, or has a pull request almost ready, and you guys could collaborate a little, or just sync so you guys don't overlap.

hailg commented 11 years ago

Hi, currently I'm working on a project likes Line or WeChat. At mobile side, we are using:

  1. Xmppframework (https://github.com/robbiehanson/XMPPFramework): to connect to our ejabberd server and do XMPP stuff.
  2. Modify webrtc-jingle-client to share the same socket with xmppframework (because Apple allow only 1 socket to be alive in background mode)
  3. UI stuff including: login screen, chats screen, contacts screen, in-called screen, call notification,... So, actually, our project maybe suit with your need and we will post it on github when we have the first runnable version. It is maybe at the end of this month (March 2013).
jlavyan commented 11 years ago

hi, Thank you then ok, I need video too I will work on video geting video call, then we can add h264 hardware encode functionality too I will focus on video, getting first video call then improve that Thanks

jlavyan commented 11 years ago

and one question have work adding AudioUnit echo cancelation on that os not ? I think apple AudioUnit AEC more better Thanks

lukeweber commented 11 years ago

In response to AEC for apple, I noticed in the latest code, they seem to be disabling AEC from webrtc, so I think this is covered.

if defined(IOS)

// On iOS, VPIO provides built-in EC and AGC. options.echo_cancellation.Set(false); options.auto_gain_control.Set(false);

https://code.google.com/p/libjingle/source/browse/trunk/talk/media/webrtc/webrtcvoiceengine.cc

I'll try to merge all of this code in today.