search

lulalala / multi_logger

Create multiple loggers in Rails
MIT License
59 stars 21 forks source link

Custom log filename #9

Closed karuppasamy closed 10 years ago

karuppasamy commented 10 years ago

Added custom logger filename instead of using the same of method name.

lulalala commented 10 years ago

Hihi, thanks for taking the time to rewrite :D

I found one bug and two behavior changes, so I wrote some tests (https://github.com/lulalala/multi_logger/commit/710fec07941b306b4097b87114d9bff37cc2e179).

Can you rebase your changes on top of the latest master, and correct the regressions? You can run tests by running rake test.

Thanks so much~

lulalala commented 10 years ago

And sorry about one thing. I just realized that the gem already has a "path" option which you can set to change log file name. So the file_name is redundant. Sorry I missed this because it is done by someone else which I didn't use so I forgot about it.

So once you fix the tests I'll merge the refactor part.

karuppasamy commented 10 years ago

There is not much refactor.. Anyway I have requested as separate one https://github.com/lulalala/multi_logger/pull/10

lulalala commented 10 years ago

Thanks for your work and sorry about forgetting that :(