search

lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
162 stars 18 forks source link

Bookmark button not saving bookmarks when recording is finished. #169

Closed MrMK0R closed 1 month ago

MrMK0R commented 10 months ago

I am not sure if this is the intended use for the bookmark feature, but when recording, and hitting the bookmark shortcut, the bookmark doesn't show in the video.

Steps: 1 - bind bookmark button and enable bookmarks 2 - start game with recording 3 - make a play and hit bookmark button 4 - end recording 5 - Bookmarks added during recording don't show in video preview.

Segergren commented 10 months ago

Can you attach the logs?

MrMK0R commented 10 months ago

Here is current log logs.txt

lulzsun commented 10 months ago

It looks like it properly registers the keybind on press, so this issue might be related to how we are currently storing bookmarks in localStorage of the WebView.

If we complete #84, this may solve the issue. I might get around doing that soon, but no promises.

lulzsun commented 1 month ago

This issue should be fixed by https://github.com/lulzsun/RePlays/commit/eb78b562cd4071e45270083a59752387bae9e5b5

Will still be looking to move bookmarks/metadata out of local storage.

Segergren commented 1 month ago

Nice find @lulzsun!