lunixbochs / revsync

realtime cross-tool collaborative reverse engineering
MIT License
100 stars 25 forks source link

Fix bugs in binja frontend #10

Closed zackorndorff closed 2 years ago

zackorndorff commented 2 years ago

Fixed a couple bugs in the binja frontend, see commit messages for details.

The duplicate symbol fix seems to cost 2% CPU on my M1 mac, which isn't ideal, but having spurious renames is worse.

I've looked into using Binja's callbacks to move away from polling, but they don't seem to be working for me; I opened a GH issue earlier this week so the devs should get to it at some point.