search

lushen124 / Universal-FE-Randomizer

Properly universal this time.
MIT License
98 stars 28 forks source link

Issue #395 fix NPE when FE7 Lords not in randomized recruitment #400

Closed Geeene closed 1 year ago

Geeene commented 1 year ago

the issue here is that the randomizer takes the characters from the Map that contains the Randomized Character mapping. This map will not contain Lyn / Eliwood / Hector, if they aren't being randomized. So when the randomizer tries to get them from the map it blows up since it can't find them, and currently only checks that the Map exists, not that the character also is in the map.

Since at this point it is an expected scenario, we should check that if the lords are not in the map, then we just use the default Lyn / Eliwood / Hector character slot, since they aren't randomized.

lushen124 commented 1 year ago

Should be fine. Alternative method would be to map Lyn to Lyn in the character map when we generate it, but 👍 .