search

lushen124 / Universal-FE-Randomizer

Properly universal this time.
MIT License
98 stars 28 forks source link

Palettes for FE7 #402

Open BrannonMurphy opened 1 year ago

BrannonMurphy commented 1 year ago

Whenever Lyn is randomized, and the Lyn Lord class is used, the palette doesn't apply. For instance, if Lyn gets replaced by Louise and the class is Lord Lyn, the preview will show the palette with Louise's colors applied, but using it in Lyn Mode will not apply it. Combat just shows Lyn's standard colors

BrannonMurphy commented 1 year ago

image image

This also applies to Nino from experience. And Rebecca

BrannonMurphy commented 1 year ago

I also discovered some others, if it helps:

Wallace as a thief is just Matthew's palette Ninian as a pegasus is just Florina's palette [not 100% sure] Eliwood as a fighter is just Dorcas's palette Ninian as a female archer is just Rebecca's palette Wallace as a paladin has Marcus's palette

Geeene commented 1 year ago

I tried forcing this issue by forcing the chars into the classes you suggested during class randomization:

2023-03-22 17_51_51-Yune - Universal FE Randomizer_src_random_gba_randomizer_ClassRandomizer java -

2023-03-22 17_49_51-Character Palette test gba

2023-03-22 17_56_22-Character Palette test gba Looks perfectly fine. Would probably be best if you provide the changelog if it happens again

lushen124 commented 1 year ago

Just to add: There is logic to abandon palette changes if there aren't enough palettes available to assign them. I don't remember if it can happen in FE7, but it is primarily something to handle for FE6, as many characters actually don't have palettes and rely on the default palette. IIRC, lords may not have palette info because it's baked into their unique class. Something worth looking into. Alternatively it may be a bug that it's triggering that logic when it shouldn't be.