search

lusingander / serie

A rich git commit graph in your terminal, like magic 📚
MIT License
435 stars 13 forks source link

Neither protocol working in VSCode integrated #26

Closed uncenter closed 3 months ago

uncenter commented 3 months ago

https://github.com/lusingander/serie#inline-images-protocol lists the VSCode integrated terminal as supported with the iterm protocol, however I'm not able to see the graph with either protocol.

alerque commented 3 months ago

Same here with the open source vscode build on Linux. I suspect (but guessing, don't know) this is because the heavy lifting for the terminal widget is pawned off on something else platform specific, and on macOS that might be an embedded iTerm or something like that.

uncenter commented 3 months ago

I think you are right. Looking at image protocol support for another program again, Yazi, looks like VSCode is supposed to work with inline images - and you guessed it, somehow relating to iTerm. Not seeing Yazi's image support work in VSCode's terminal either.

uncenter commented 3 months ago

Ah, maybe this will help? 😃

CleanShot 2024-08-02 at 09 22 15@2x

uncenter commented 3 months ago

Yep, that did it ahah. Looks like it is disabled by default? That should be noted in the support table, https://code.visualstudio.com/docs/terminal/advanced#_image-support could be linked here as well.