lustre-labs / lustre

A Gleam web framework for building HTML templates, single page applications, and real-time server components.
https://hexdocs.pm/lustre
MIT License
948 stars 66 forks source link

🧪 move tests into test directory, bump birdie to ignore non-gleam files #124

Closed JScearcy closed 4 months ago

JScearcy commented 4 months ago

This is a an approach to testing a built lustre application.

JScearcy commented 4 months ago

Some feedback from Hayleigh:

  1. Move config files to root, such as vitest config, package.json, etc
  2. Configure snapshot location if possible to follow the same pattern as birdie - such as a vitest_snapshots directory
  3. Test directories like test/counter_app_test/test/counter-app.test.js are maybe too verbose
  4. Simplify the relative paths
  5. Use lustre/dev build app for builds
  6. Drop esbuild
hayleigh-dot-dev commented 4 months ago

Incredible stuff. This is going to be insanely valuable. I'm going to merge this and then maybe tweak some bits if I find time, thank you so much!